[ACR] Add Viewpoint Synchronization #13068
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenohedron
reviewed
Nov 17, 2024
|
|
||
| if (target.getTargets().size() >= 2) { | ||
| Cards cardsToHand = new CardsImpl(revealed); | ||
| while (cardsToHand.size()>1) { |
There was a problem hiding this comment.
Don't use a while loop. Instead, increase the max number of targets on the TargetCardInLibrary.
I'm not a fan of this code duplication. Instead, consider if you can accomplish it by adding an int numToBattlefield parameter to the common class you copied this from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://scryfall.com/card/acr/43/viewpoint-synchronization
There was no clean way to put more than two permanents to the battlefield, that I could find.
That's why I wrote a small Effect for that to be used. It feels okay to use in GUI, but I bet there is a better way as well.
Happy to receive feedback :)