new ExileReturnBattlefieldNextEndStepTargetEffect #11251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xenohedron
commented
Oct 3, 2023
xenohedron
commented
- closes Refactor: regroup together the Mistmeadow Witch kind of effect #10978
JayDi85
reviewed
Oct 3, 2023
| @@ -50,15 +49,15 @@ public ExileThenReturnTargetEffect copy() { | |||
| @Override | |||
| public boolean apply(Game game, Ability source) { | |||
| Player controller = game.getPlayer(source.getControllerId()); | |||
| Set<Card> toFlicker = new LinkedHashSet<>(); | |||
There was a problem hiding this comment.
Correct replacement of LinkedHashSet by streams (don't use toSet, cause it can random cards order):
https://stackoverflow.com/a/51945053
There was a problem hiding this comment.
Why is the order necessary?
There was a problem hiding this comment.
Its related to UX. Example: users must see same logs and same GUI requests for same actions. LinkedHashSet helps to save that order.
There was a problem hiding this comment.
Hmm, well, this is probably a much broader issue in the codebase then (indiscriminate use of HashSet<> rather than LinkedHashSet<> in addition to the Collectors.toSet()). I'll fix it here at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.