-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WOC] Implement Court of Locthwain #10973
Conversation
Unable to retrieve information for "Court of Lochtwain" |
Court of Locthwain - (Gatherer) (Scryfall) (EDHREC)
|
2194190
to
24fbc85
Compare
Ok this PR is a mess, but in the end it works. |
Mage.Server.Plugins/Mage.Game.BrawlFreeForAll/src/mage/game/BrawlFreeForAll.java
Outdated
Show resolved
Hide resolved
8c9f96c
to
c2bbd0a
Compare
I consider Court of Locthwain working with the rework of AsThough effects (I did test it live, and with unit tests). I'll look into some of the known bugs of AsThough and see if I can also make them work from this point in other PRs. |
Can you describe what you've changed about AsThoughEffect in this PR?
|
|
9bbed4b
to
49d5cf5
Compare
Okay, I'm fine with the card and unit tests in this PR with the rework then, and the other PR #11114 to fix those old bugs can be rebased after this is merged. The other issue of the side effects in applies method can be revisited separately. Please address all feedback from #11114, and update PR title and description to clearly explain what is being changed and why. |
Current plan is to rework the effects in #11114, then I'll rebase this PR with it. |
49d5cf5
to
086abd4
Compare
Rebased now that the AsThough rework has been merged. Everything works well. |
public boolean apply(Game game, Ability source) { | ||
Player controller = game.getPlayer(source.getControllerId()); | ||
Player opponent = game.getPlayer(getTargetPointer().getFirst(game, source)); | ||
if (controller == null || opponent == null || source == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(no need to null check source; indeed you've already called getControllerId() on it at this point)
So in this WIP, it is not possible to choose to cast for free. Commenting out "you may play" part:
does unlock the ability to "you may cast without paying manacost". So I think there is an issue with two competing AsThoughEffect not letting the player choose the appropriate one.