Tyvar the Bellicose ability not resolving for all Elves

[skaspels]

I've been playing a Tyvar edh deck for some time, and when elves have a mana ability granted from another source, the mana ability doesn't trigger Tyvar when it resolves.

Ex: I have a Level 5 Joraga Treespeaker, Tyvar the Bellicose, and Gnarlroot Trapper. If I use Gnarlroot trapper's t: add {B} ability, Tyvar's ability triggers and Gnarlroot gets a +1/+1 counter. If instead I use Gnarlroot trapper's t: Add {GG} ability granted by Joraga Treespeaker, Tyvar's ability does not trigger. I have found this happens very consistently across games.

[xenohedron]

[[Tyvar, the Bellicose]]

Relevant code is here in the custom triggered ability, not immediately obvious to me what the issue is, so maybe buried in the getAbility:

    public boolean checkTrigger(GameEvent event, Game game) {
        if (isControlledBy(event.getPlayerId())
                && event.getSourceId().equals(getSourceId())
                && game
                .getAbility(event.getTargetId(), event.getSourceId())
                .map(ManaAbility.class::isInstance)
                .orElse(false)) {
            this.getEffects().setValue("damage", event.getAmount());
            return true;
        }
        return false;
    }

[github-actions]

Tyvar the Bellicose - (Gatherer) (Scryfall) (EDHREC)

{2}{B}{G}
Legendary Creature — Elf Warrior
5/4
Whenever one or more Elves you control attack, they gain deathtouch until end of turn.
Each creature you control has "Whenever a mana ability of this creature resolves, put a number of +1/+1 counters on it equal to the amount of mana this creature produced. This ability triggers only once each turn."

[skaspels]

I would guess, based on what I'm reading there, that the problem is the
&& event.getSourceId().equals(getSourceId())
part of the 'if' statement - the event's target (the creature) and the source (the thing giving the creature the mana ability) aren't the same. perhaps this needs to be modified.

[xenohedron]

Nope, looks like the problem is that game.getAbility(event.getTargetId(), event.getSourceId()) is returning an empty Optional when it is an ability being granted to the creature from another source.

[xenohedron]

You know what, this might be related to #11077, if perhaps the gained ability has a new id by the time checkTrigger tries to find it.

[skaspels]

I guess that makes sense - the game is trying to distinguish between being the creature tapping for mana as a mana ability, vs being tapped by another card, like [[Relic of Legends]] (which wouldn't trigger Tyvar).

As to your second comment, I don't know what the ability would have a new ID when checkTrigger tries to find it, but then I don't understand the code very well at all.

[github-actions]

Relic of Legends - (Gatherer) (Scryfall) (EDHREC)

{3}
Artifact
{T}: Add one mana of any color.
Tap an untapped legendary creature you control: Add one mana of any color.

[jeffwadsworth]

[[Joraga Treespeaker]] [[Gnarlroot Trapper]]

[github-actions]

Joraga Treespeaker - (Gatherer) (Scryfall) (EDHREC)

{G}
Creature — Elf Druid
1/1
Level up {1}{G} ({1}{G}: Put a level counter on this. Level up only as a sorcery.)
LEVEL 1-4
1/2
{T}: Add {G}{G}.
LEVEL 5+
1/4
Elves you control have "{T}: Add {G}{G}."

Gnarlroot Trapper - (Gatherer) (Scryfall) (EDHREC)

{B}
Creature — Elf Druid
1/1
{T}, Pay 1 life: Add {G}. Spend this mana only to cast an Elf creature spell.
{T}: Target attacking Elf you control gains deathtouch until end of turn. (Any amount of damage it deals to a creature is enough to destroy it.)

[jeffwadsworth]

The event MANA_ADDED fires whether a mana source is used or not. Make sure to test cards like Gnarlroot Trapper before anything else. Caged Sun is the only other card using this event trigger.