Merged
Conversation
Vinai
approved these changes
Dec 4, 2023
mage-os-ci
pushed a commit
that referenced
this pull request
Feb 6, 2026
…ethods
Fixed 3 test failures by using proper PHPUnit 12 pattern.
Files fixed:
1. AbstractBlockTest::testGetVar - 1 test ✅
- Changed deprecated createMock(AbstractBlock, $constructorArgs)
- To: getMockBuilder()->setConstructorArgs()->onlyMethods([])->getMock()
2. SearchResultTest - 2 tests ✅
- Changed createMock(SearchResult) which returns null for all methods
- To: getMockBuilder()->onlyMethods([])->getMock()
- This allows real method implementations (setTotalCount, getTotalCount, etc.)
Pattern: When tests need real method implementations to work:
$mock = $this->getMockBuilder(Class::class)
->disableOriginalConstructor() // Skip constructor if needed
->onlyMethods([]) // Don't override any methods
->getMock();
This creates a partial mock that allows all real methods to execute while
still being able to configure specific method behaviors if needed.
Commit #64 - Fixed 3 more test failures
Remaining: 12 failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Github workflow for automatically running Integration Tests for the code that has changed in a PR. (Leveraging Nx).
Related Pull Requests
https://github.com/mage-os/github-actions/pull/184/files
Contribution checklist (*)