Add inputs to mage-os/github-actions/coding-standard-baseline#59
Merged
sprankhub merged 1 commit intomage-os:2.4-developfrom Nov 16, 2023
Merged
Add inputs to mage-os/github-actions/coding-standard-baseline#59sprankhub merged 1 commit intomage-os:2.4-developfrom
sprankhub merged 1 commit intomage-os:2.4-developfrom
Conversation
13 tasks
sprankhub
approved these changes
Nov 16, 2023
mage-os-ci
pushed a commit
that referenced
this pull request
Feb 6, 2026
…PHPUnit 12 pattern
CRITICAL FIX: Removed deprecated getMockForAbstractClass() usage.
Issue: getMockForAbstractClass() is deprecated in PHPUnit 12
Solution: Use getMockBuilder()->onlyMethods([])->getMock()
Files fixed:
1. AbstractModelTest.php - 18 tests
2. AbstractFactoryTest.php - 9 tests
3. ProfilerTest.php - 1 skipped test (cleanup)
PHPUnit 12 Pattern for Abstract Classes:
✅ CORRECT:
$mock = $this->getMockBuilder(AbstractClass::class)
->setConstructorArgs([$args])
->onlyMethods([]) // Don't override any methods
->getMock();
❌ WRONG (Deprecated):
$mock = $this->getMockForAbstractClass(AbstractClass::class, [$args]);
The onlyMethods([]) tells PHPUnit to create a partial mock that:
- Allows all real method implementations to work
- Only mocks what's explicitly configured
- Works with abstract classes by creating a concrete instance
Commit #59 - Removed all deprecated getMockForAbstractClass()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See mage-os/github-actions#189 for more info.