Skip to content

Conversation

@rhoerr
Copy link
Contributor

@rhoerr rhoerr commented Sep 23, 2023

Description (*)

Basic rebranding of the admin theme, without any structural changes. Shifts the color scheme to blues, gets rid of dark table headers, adds border radius to fields, and other small adjustments.

Related Pull Requests

Builds on #21 for Mage-OS logo and brand changes

Manual testing scenarios (*)

  1. Deploy static content
  2. Access admin panel
  3. Confirm admin panel looks good

Questions or comments

I am not a designer, and this is an early and relatively small effort, so there is room for improvement. But I think this is an accessible and meaningful improvement over the existing theme, and provides a direction for improvement over time.

There's been discussion of greater improvements (like changing the menu to purely CSS for performance and stability), but in the interest of time I've stuck to minor style changes only at this point. Others are more than welcome to propose further and deeper changes, provided the changes won't cause issues for compatibility.

Screenshots of the work to date:
Screenshot 2023-09-22 214749
Screenshot 2023-09-22 214937
Screenshot 2023-09-22 214952
Screenshot 2023-09-22 215112
Screenshot 2023-09-22 215253

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@rhoerr rhoerr requested a review from a team as a code owner September 23, 2023 02:13
@rhoerr
Copy link
Contributor Author

rhoerr commented Sep 23, 2023

Note, I chose green for the main button color rather than Mage-OS orange because the contrast of white on green is far better than white on orange (5.5 vs 2.3). More readable and accessible.

@rhoerr
Copy link
Contributor Author

rhoerr commented Sep 24, 2023

I fixed the coding standard warnings, and made some other small adjustments (better odd-row color, fixed gray hover background throughout; red flush-cache button).

The one lingering standards warning is a false positive; it is correctly indented.

FILE: ...to2/app/design/adminhtml/Magento/backend/web/css/styles-old.less
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
 783 | WARNING | Line indented incorrectly; expected 4 spaces, found 8
 784 | WARNING | Line indented incorrectly; expected 4 spaces, found 8
 785 | WARNING | Line indented incorrectly; expected 4 spaces, found 8
 786 | WARNING | Line indented incorrectly; expected 4 spaces, found 8
----------------------------------------------------------------------

@rhoerr
Copy link
Contributor Author

rhoerr commented Sep 26, 2023

I'll adjust the fly-out menu title gray color for better contrast.

@rhoerr
Copy link
Contributor Author

rhoerr commented Sep 30, 2023

I've adjusted that header text color. Color contrast is now 7.68.

image

@Vinai Vinai merged commit c0c47fa into mage-os:2.4-develop Oct 7, 2023
@rhoerr rhoerr deleted the mageos-admin-rebrand branch November 14, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants