Merged
Conversation
Closed
Contributor
Author
sprankhub
reviewed
Aug 1, 2023
Member
There was a problem hiding this comment.
I am hesitant to add a file to the root directory. Would it be an idea to add it to .github/workflows/ instead?
Contributor
Author
There was a problem hiding this comment.
I thought it got approved in a previous meeting (quite a while ago now).
Ideally I'd like it to go in root, just so it can be part of a release. This way there would be a way to programatically determine what services a specific version of mage-os supports / has been tested.
I was also intending to leverage this file with the integration tests.
What do you think?
Member
There was a problem hiding this comment.
Fair enough, why not. No hard feelings here :)
sprankhub
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)