Phpcs Baseline testing #24
Conversation
sprankhub
left a comment
sprankhub
left a comment
There was a problem hiding this comment.
Thanks for your work! I hope my comments make sense to you :)
There was a problem hiding this comment.
I do not think we should have a new directory coding-standard in the root directory. IMHO, the action should be included here directly. So the steps from coding-standard/action.yml can simply be included here.
There was a problem hiding this comment.
We have tried without that coding-standard folder, when we try to get input variables without that folder, its not getting those values. So we have put that as it is for now. Please review
There was a problem hiding this comment.
I think the correct way would be to move the action to https://github.com/mage-os/infrastructure and just call it here similar to the PHP Unit Test action being prepared in mage-os/infrastructure#34.
There was a problem hiding this comment.
okay, will discuss on this
There was a problem hiding this comment.
I agree with @sprankhub, we don't want a new folder in the project root for CI purposes. I know it is not necessary, the input variables do not depend on it.
There was a problem hiding this comment.
Thanks for confirming, @Vinai. Then this PR needs to be split up into one PR to https://github.com/mage-os/infrastructure and one PR into this repo here.
coding-standard/action.yml
Outdated
There was a problem hiding this comment.
I think .php is not enough. We also need to add .phtml and maybe more.
There was a problem hiding this comment.
we have added .phtml now, which others are required to add ? phpcs only works for php code base.
There was a problem hiding this comment.
There was a problem hiding this comment.
It looks like more files are checked by phpcs - did you have a look?
4 participants
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)