Generalize product metapackage detection for alternate metapackages

[rhoerr]

The system package detection was previously hardcoded to only recognize packages matching mage-os/product-*-edition. This change generalizes the regex to match any mage-os/product-* package, enabling support for alternate product metapackages like mage-os/product-minimal.

• Update isSystemPackage() regex to match any mage-os/product-* package
• Update getRequiredPhpVersion() to use isSystemPackage() instead of hardcoded product-community-edition
• Add unit tests for isSystemPackage() with various package patterns
• Update ProductMetadataTest to use proper mage-os package names

Description (*)

Improves flexibility of product version loading for different product package names

Related Pull Requests

#115

Fixed Issues (if relevant)

1. Fixes mage-os/mageos-magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[rhoerr]

Tested, this works. I'm going to fix the fundamental issue by renaming mage-os/product-minimal to mage-os/product-minimal-edition, but it'll still be best to loosen the pattern and remove the hardcoded product-community-edition.

[marcelmtz]

Seems that the integration test needs to get fixed, could be that we need to change the sort order of the constants in https://github.com/mage-os/mageos-magento2/blob/release/3.x/dev/tests/integration/testsuite/Magento/Framework/Interception/PluginListGeneratorTest.php
Something like (not tested, just throwing ideas):
const CACHE_ID_FRONTEND = 'frontend|global|primary|plugin-list'; const CACHE_ID_DUMMY = 'dummy|global|primary|plugin-list';

[rhoerr]

Seems that the integration test needs to get fixed, could be that we need to change the sort order of the constants in https://github.com/mage-os/mageos-magento2/blob/release/3.x/dev/tests/integration/testsuite/Magento/Framework/Interception/PluginListGeneratorTest.php Something like (not tested, just throwing ideas): const CACHE_ID_FRONTEND = 'frontend|global|primary|plugin-list'; const CACHE_ID_DUMMY = 'dummy|global|primary|plugin-list';

Thanks, good spot. That came from another recent PR #194 -- the test does need to be fixed to match the corrected behavior so we pass again. Functionally it's fine.

[marcelmtz]

The integration test will get tackled separately, approved (as it comes from other pr)

[rhoerr]

Thanks! We need to get you added to the review groups in Terraform so that actually counts. 😄