Skip to content

Upstream Merge Conflict (2.4-develop)#152

Merged
fballiano merged 45 commits into2.4-developfrom
2.4-develop-upstream
Aug 13, 2025
Merged

Upstream Merge Conflict (2.4-develop)#152
fballiano merged 45 commits into2.4-developfrom
2.4-develop-upstream

Conversation

@mage-os-ci
Copy link
Contributor

This PR was automatically generated: a human is required.

CONFLICT (modify/delete): app/code/Magento/CatalogRule/etc/config.xml deleted in e347a9f and modified in HEAD. Version HEAD of app/code/Magento/CatalogRule/etc/config.xml left in tree.
Auto-merging app/code/Magento/Customer/etc/config.xml
CONFLICT (content): Merge conflict in app/code/Magento/Customer/etc/config.xml
Auto-merging app/code/Magento/Quote/etc/di.xml
Auto-merging app/code/Magento/SalesRule/etc/config.xml
CONFLICT (content): Merge conflict in app/code/Magento/SalesRule/etc/config.xml
Automatic merge failed; fix conflicts and then commit the result.

cod40403 and others added 30 commits May 6, 2025 11:44
Co-authored-by: Deepak Soni <deepaksoni@adobe.com>
LYNX-892: [AC-2.4.9] Introduce OrderTotal.grand_total_excl_tax field
LYNX-889: [AC-2.4.9] Merging guest and customer cart logic using Admin Configuration
@fballiano
Copy link
Contributor

this conflict should be fairly easy to solve, it impacts only 3 xml files

Screenshot 2025-08-13 alle 14 28 02
  1. I'd merge this result (circled in red)
Screenshot 2025-08-13 alle 14 29 11
  1. I'd merge this result (circled in red)
Screenshot 2025-08-13 alle 14 30 33

3 I'm in doubt because I'd keep our change but upstream deleted the file... so I don't know what to do, actually I'd keep our file
Screenshot 2025-08-13 alle 14 32 02

@rhoerr what do you think?

@rhoerr
Copy link
Contributor

rhoerr commented Aug 13, 2025

In all three cases, we can take the upstream changes (deleting those lines/file). Upstream added that code in 2.4.8. We disabled by default in #135 and #136. Upstream has now reverted the whole feature, making our fix unnecessary. Reverting to the core code will prevent future conflicts on this.

@fballiano
Copy link
Contributor

done!

Copy link
Contributor

@rhoerr rhoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving upstream merge conflict resolve

@rhoerr rhoerr marked this pull request as ready for review August 13, 2025 13:47
@rhoerr rhoerr requested a review from a team as a code owner August 13, 2025 13:47
@fballiano fballiano merged commit 84200ef into 2.4-develop Aug 13, 2025
7 of 11 checks passed
@fballiano fballiano deleted the 2.4-develop-upstream branch August 13, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants