Skip to content

Update TinyMCE config to match Magento_CMS config#4

Merged
fballiano merged 1 commit intomage-os:release/1.xfrom
rhoerr:feat/update-tinymce-config
Nov 4, 2024
Merged

Update TinyMCE config to match Magento_CMS config#4
fballiano merged 1 commit intomage-os:release/1.xfrom
rhoerr:feat/update-tinymce-config

Conversation

@rhoerr
Copy link
Copy Markdown

@rhoerr rhoerr commented Nov 4, 2024

Description (*)

This updates the PageBuilder TinyMCE config to match what we have set for upstream in Magento_CMS.

The new settings are added with array_replace_recursive, meaning any existing additionalSettings should still override them, preserving compatibility and existing behavior. The values can be modified with DI XML or an after plugin, so I do not think splitting it out further is necessary. This should minimize risk of breaking changes.

Reference: https://github.com/rhoerr/mageos-magento2/blob/de194a0185ee3c03cb7c9d14c6b1802486b5ea07/app/code/Magento/Cms/Model/Wysiwyg/DefaultConfigProvider.php

I have not checked or updated any applicable MFTF tests, as we don't use that testing suite.

Story

Bug

Task

Fixed Issues (if relevant)

Builds

Related Pull Requests

mage-os/mageos-magento2#109

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@rhoerr rhoerr requested a review from fballiano November 4, 2024 13:52
@fballiano
Copy link
Copy Markdown

it seems perfect

@fballiano fballiano merged commit 0b59d4b into mage-os:release/1.x Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants