Issue/2593 Upgrade Typescript Project to Use Project References#2650
Merged
AlexGilleran merged 40 commits intomasterfrom Dec 11, 2019
Merged
Issue/2593 Upgrade Typescript Project to Use Project References#2650AlexGilleran merged 40 commits intomasterfrom
AlexGilleran merged 40 commits intomasterfrom
Conversation
increase the cache key
- remove noEmitOnError from global as it's not appropriate for project reference setup - add tsbuildinfo to gitignore
…ssue. Reason: - terriajs requires lower version (0.2.17) `loader-utils` which is common utils lib of many webpack plugins - Due to webpack upgrade of other magda modules, a newer version of webpack is hoisted to the root which was 3.12.0. This lead to newer version of `loader-utils` is loaded by webpack but can't process old API calls from old version webpack plugins used by terriajs. This lead to incompleted CSS build.
3 tasks
AlexGilleran
approved these changes
Dec 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #2593
Re-created from the previous PR to reduce moving pieces using ts-module-alias-transformer.
ts-module-alias-transformerstill usesbabel-coreto replace the module path. But because it bundled all libs into one single built file (including @babel/core). there is no dependencies required.A separated
.babelrcis not required either.Test:
Test site:
http://issue-2593-alt.dev.magda.io/
Checklist