Skip to content

Parse 'approach NACK' as AckType::ApproachNack #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maflcko merged 1 commit into from
Jan 5, 2026
Merged

Parse 'approach NACK' as AckType::ApproachNack #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions webhook_features/src/features/summary_comment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,10 +430,10 @@ impl AckType {

lazy_static! {
static ref ACK_PATTERNS: Vec<(Regex, AckType)> = vec![
(r"\b(Approach ACK)\b", AckType::ApproachAck),
(r"\b(Approach NACK)\b", AckType::ApproachNack),
(r"\b([Aa]pproach ACK)\b", AckType::ApproachAck),
(r"\b([Aa]pproach NACK)\b", AckType::ApproachNack),
(r"\b(NACK)\b", AckType::ConceptNack),
(r"\b(Concept ACK)\b", AckType::ConceptAck),
(r"\b([Cc]oncept ACK)\b", AckType::ConceptAck),
(r"(ACK)(?:.*?)([0-9a-f]{6,40})\b", AckType::Ack),
(r"(ACK)\b", AckType::ConceptAck)
]
Expand Down Expand Up @@ -629,13 +629,27 @@ mod tests {
commit: None,
}),
},
TestCase {
comment: "Concept ACK, but approach NACK",
expected: Some(AckCommit {
ack_type: AckType::ApproachNack,
commit: None,
}),
},
TestCase {
comment: "Concept NACK",
expected: Some(AckCommit {
ack_type: AckType::ConceptNack,
commit: None,
}),
},
TestCase {
comment: "concept NACK",
expected: Some(AckCommit {
ack_type: AckType::ConceptNack,
commit: None,
}),
},
TestCase {
comment: "NACK this change!",
expected: Some(AckCommit {
Expand All @@ -648,7 +662,7 @@ mod tests {
expected: None,
},
TestCase {
comment: "This is a Concept ACK for me!",
comment: "This is a concept ACK for me!",
expected: Some(
AckCommit {
ack_type: AckType::ConceptAck,
Expand Down