Correctly detect unref'ed handles #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point, Timeout objects aren't the only handles that have a hasRef() method. nodejs/node#42756 added hasRef() to the Worker handle object that gets reported by async_hooks, so we should consider that too. Fixes: mafintosh#59 Signed-off-by: Darshan Sen <[email protected]>
mafintosh
reviewed
Apr 25, 2022
|
2.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point,
Timeoutobjects aren't the only handles that have ahasRef()method. nodejs/node#42756 addedhasRef()to theWorkerhandle object that gets reported byasync_hooks,so we should consider that too.
Fixes: #59
Signed-off-by: Darshan Sen [email protected]