Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in the code #68

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Fix a typo in the code #68

merged 1 commit into from
Jun 20, 2018

Conversation

wewei
Copy link
Contributor

@wewei wewei commented Jan 29, 2018

Problem:

When using the tar-fs with custom fs, the mkdirp method still use the standard fs. The root cause is a typo in mkdirfix method. The file system object is passed with fs option, but consumed through xfs.

Fix:

Replace xfs with fs in mkdirfix.

@wewei
Copy link
Contributor Author

wewei commented Jan 29, 2018

@mafintosh , thanks for developing tar-fs, it's a great utility package. We need to use the package with custom fs, this is a blocking issue. If the simple fix looks fine, would you help to publish a new patch?

Thanks a lot.

@mafintosh mafintosh merged commit 570eefb into mafintosh:master Jun 20, 2018
@mafintosh
Copy link
Owner

Awesome. 1.16.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants