fix: node compat

[ronag]

No description provided.

[ronag]

I'm actually unsure what this module does differently from just doing a .read()?

[mafintosh]

@ronag docs say it returns all the data concatted if no size is provided (havent tested myself in a while so unsure). The point of this is to return the next buffer chunk that was pushed to the stream. if thats what the stream does indeed then yea obvs easier to do that.

ie

stream.push(Buffer.from('a'))
stream.push(Buffer.from('b'))

shift(stream) // buffer('a')
shift(stream) // buffer('b')

[ronag]

I will double-check and get back to you!

[ronag]

As far as i can tell, if you don't pass anything into read it will give you the first buffer:

https://github.com/nodejs/node/blob/main/lib/internal/streams/readable.js#L634

But it's not entirely clear. I think it only applies if it's "flowing".

[ronag]

This really needs some review, either way, in my opinion read() should always return the first buffer. If that's not the case we should probably fix it. Either way, I'm pretty sure the current state of this PR will make things better.

[mafintosh]

It doesnt for me in node 20. ie

const { Readable } = require('stream')

const rs = new Readable({ read () { } })

rs.push(Buffer.from('a'))
rs.push(Buffer.from('b'))

console.log(rs.read())

Prints <Buffer 61 62>

[mafintosh]

Thanks though @ronag , merging this for now.

[mafintosh]

1.0.3

[nadavzipo]

@mafintosh any chance you bumping https://github.com/mafintosh/duplexify to use 1.0.3?
It will fix googleapis/nodejs-storage#2391 issue.
Thanks!