Add failing pumpify test

[phated]

Hey @mafintosh, I just ran into this issue within the published release of gulp 4. It seems that using pumpify with end-of-stream swallows any errors that happen in the middle of the pumpify stream and instead emit a "premature close" error.

I've created a simplified reproduction case in the tests but I'm not too sure which module needs the fix or what to actually fix. Thoughts?

cc @erikkemperman

[mafintosh]

Thanks. That does indeed seem wrong. Will take a look today

[mafintosh]

This was a pumpify bug. Fixed it there and added a test. Can you verify it works for you now if you reinstall all the deps?

[phated]

@mafintosh awesome! I thought that might be the case. It seems like problem still exists. I've bumped the pumpify version in the devDeps to show in this reduced case.

[phated]

It seems that using 3 through() streams for the pipeline works but having a Writable at the end causes the failure. I'll push a succeeding and a failing test.

[phated]

Hey @mafintosh - anything else I can help with here?

[phated]

Friendly ping

[mafintosh]

@phated turns out this was an issue in pumpify, fixing it there.

[mafintosh]

@phated should be fixed now! for good hopefully :) i ended up moving the tests to pumpify as it was an issue there.

[phated]

Awesome! Thanks @mafintosh 😸