Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Add package revision parameter, fix NDK install, check package exists #45

Closed
wants to merge 11 commits into from
Closed

Add package revision parameter, fix NDK install, check package exists #45

wants to merge 11 commits into from

Conversation

jamiesnape
Copy link
Contributor

  1. Add revision parameter to android::package and related defines:
    1. present ensures some revision of the package is installed and does not upgrade the package when a new version is available.
    2. 'n' ensures that if revision 'n' of the package is installed, then it is not upgraded. Due to limitations of the android tool, if revision 'n' is not installed, then the latest revision will be installed. Fixes Found a way to update packages to certain revision, pull request? #34.
    3. latest ensures that the latest revision of the package is installed and upgrades the package when a new version available. Fixes Is there a way to upgrade tools and platform-tools? #26.
  2. Ensure the NDK is installed by $android::user by running the installer as $android::user. Fixes NDK ownership #43.
  3. Check that a package exists before trying to install it. Fixes Return an error on failed packages - not working again, apparently.  #36.
  4. Lint and documentation.

(Tested on OS X 10.11, Debian 7, and Ubuntu 14.04, 15.10)

Jamie Snape added 10 commits December 30, 2015 14:16
'present' ensures some revision of the package is installed and does not upgrade
the package when a new version is available.

'<revision number>' ensures that if <revision number> of the package is
installed it is not upgraded. Due to limitations of the android tool, if
<revision number> is not installed, the latest revision will be installed.

Fixes #34.

'latest' ensures that the latest revision of the package is installed and
upgrades the package when a new version available.

Fixes #26.
Runs the installer as the requested user.

Fixes #43.
@jamiesnape
Copy link
Contributor Author

jamiesnape commented Feb 12, 2016

@carlossg PTAL. We have been using this successfully for over a month six months, so it is well tested.

@mihelich
Copy link

mihelich commented Nov 2, 2016

@carlossg what needs to happen to get these multiple fixes merged? It looks like others are trying to build off this branch (#46), or apply similar platform fixes (#49, #50).

…into fixes-docs-validation-revision

# Conflicts:
#	manifests/sdk.pp
@carlossg
Copy link
Member

carlossg commented Nov 3, 2016

It'd be best if somebody forks this repo into @voxpupuli, as I'm not using puppet anymore.
Tests are failing too

@jamiesnape
Copy link
Contributor Author

The tests are failing before even running this change.

@jamiesnape jamiesnape closed this Feb 16, 2021
@jamiesnape jamiesnape deleted the fixes-docs-validation-revision branch February 16, 2021 00:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants