Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not crash when parsing invalid seconds #77

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Do not crash when parsing invalid seconds #77

merged 1 commit into from
Dec 17, 2020

Conversation

pnezis
Copy link
Contributor

@pnezis pnezis commented Dec 17, 2020

  • Add unit tests for extended parsing checks
  • Extracts seconds similarly to minutes

@pnezis
fix: do not crash when parsing invalid seconds
af08ad2 
- Add unit tests for extended parsing checks
- Extracts seconds similarly to minutes
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 99.569% when pulling af08ad2 on pnezis:fix-second-parser into e71467a on jshmrtn:master.

@coveralls
Copy link

coveralls commented Dec 17, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 99.569% when pulling af08ad2 on pnezis:fix-second-parser into e71467a on jshmrtn:master.

@maennchen maennchen merged commit 8b84019 into maennchen:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pnezis @coveralls @maennchen