Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Create TypeScript Intellisense file" should create const enum #67

Closed
styfle opened this issue Jul 22, 2015 · 0 comments
Closed

"Create TypeScript Intellisense file" should create const enum #67

styfle opened this issue Jul 22, 2015 · 0 comments

Comments

@styfle
Copy link
Contributor

styfle commented Jul 22, 2015

TypeScript 1.5 made a breaking change to enums. The relevant part is quoted below.

Enum reference in-lining changes

Starting with Typescript 1.5 all non-const enum members are not inlined.
Recommendation: Add the const modifier to the enum declaration to ensure it is consistently inlined at all consumption sites. See issue #2183

Can the "Create TypeScript Intellisense file" add the const modifier?
@styfle styfle mentioned this issue Jul 22, 2015
Merged
madskristensen added a commit that referenced this issue Jul 22, 2015
@madskristensen
Merge pull request #68 from styfle/patch-1
abdf867 
Declare TS as const enum Fixes #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@styfle