Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: serialization with defaultNS fails #12

Closed
jkowalleck opened this issue Sep 22, 2023 · 0 comments · Fixed by #20
Closed

bug: serialization with defaultNS fails #12

jkowalleck opened this issue Sep 22, 2023 · 0 comments · Fixed by #20
Assignees
@jkowalleck
Labels
bug Something isn't working

Comments

@jkowalleck
Copy link
Collaborator

serializer does not add namespaces to XML-attributes, so setting a defaultNS did not work.

the following will fail:

ElementTree.tostring(
  foo.as_xml(view_=_view, as_string=False, xmlns='myNS')
  method='xml',
  encoding='unicode', xml_declaration=True,
  default_namespace='myNS'
)
@jkowalleck jkowalleck mentioned this issue Sep 22, 2023
Closed
@jkowalleck jkowalleck added the bug Something isn't working label Sep 27, 2023
@jkowalleck jkowalleck self-assigned this Sep 27, 2023
jkowalleck added a commit that referenced this issue Sep 27, 2023
@jkowalleck
dif: set proper xml attributs's namespace
b353d20 
fixes #12

Signed-off-by: Jan Kowalleck <[email protected]>
jkowalleck added a commit that referenced this issue Sep 27, 2023
@jkowalleck
fix: set proper xml attributs's namespace
f1d5d9e 
fixes #12

Signed-off-by: Jan Kowalleck <[email protected]>
This was referenced Sep 27, 2023
Merged
Closed
jkowalleck added a commit that referenced this issue Oct 1, 2023
@jkowalleck
fix: xml defaultNamespace serialization and detection (#20)
59eaa5f 
* fixes:  serialization with defaultNS fails [#12](#12)
* fixes: defaultNamespace detection fails on XML-attributes when deserializing [#11](#11)

---------

Signed-off-by: Jan Kowalleck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkowalleck jkowalleck

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: xml defaultNamespace serialization and detection madpah/serializable
1 participant
@jkowalleck