Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scripts changes #34

Conversation

Denperidge
Copy link
Contributor

Updated support-scripts edi_docker_host_option

  • linux selector now uses a wildcard
  • Added prompt for when dockerhost can't be automatically determined
    • the prompt will work both for other OS's,
    • as well as when the linux/darwin docker host IP getting fails

Thanks to @madnificent for the help!

Building the image using 21.04 seems to no longer be possible
due to deprecated repositories
Thanks to @madnificent & @Riadabd !
- linux selector now uses a wildcard
- Added prompt for when dockerhost can't be automatically determined
 the prompt will work both for other OS's,
  as well as when the linux/darwin docker host IP getting fails

Thanks to @madnificent for the help!
@aliokan
Copy link
Contributor

aliokan commented Apr 13, 2023

@Denperidge In order to make the PR mergeable, can you only keep the support-scripts modifications, and reset ubuntu/python update (already on master), and bin/* changes (will be generated by the next release).

- linux selector now uses a wildcard
- Added prompt for when dockerhost can't be automatically determined
 the prompt will work both for other OS's,
  as well as when the linux/darwin docker host IP getting fails

Thanks to @madnificent for the help!
@Denperidge
Copy link
Contributor Author

Denperidge commented Apr 14, 2023

Ruh roh snafu Opened a new PR to avoid adding 50 revert commits! #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants