Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing support #26

Open
Windvis opened this issue Jan 14, 2022 · 0 comments · May be fixed by #28
Open

Testing support #26

Windvis opened this issue Jan 14, 2022 · 0 comments · May be fixed by #28

Comments

@Windvis
Copy link

Windvis commented Jan 14, 2022

At the moment the images don't bundle a browser which means we can't use it to run the tests in CI. As an alternative we use the danlynn/ember-cli images, but they don't always match the versions of madnificent/ember.

For example madnificent/ember 3.28.5 uses npm v8.3 while danlynn/ember-cli 3.28.5 uses npm v8.1.2 (which doesn't support the overrides feature).

Ideally we can use the image that we use for builds (and local development) while running the tests. Ember apps are configured to run tests in Chrome by default, but we can change the testem configuration to use any browser we want.

nvdk added a commit to nvdk/docker-ember that referenced this issue Mar 23, 2022
@nvdk nvdk linked a pull request Mar 23, 2022 that will close this issue
nvdk added a commit to nvdk/docker-ember that referenced this issue Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant