Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to the latest madnificent/ember image #244

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Update to the latest madnificent/ember image #244

merged 1 commit into from
Jan 14, 2022

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Jan 14, 2022

This image uses node 16 and npm 8.3 so we pin those versions for volta users and also update the lock file to match that setup.

@Windvis
Copy link
Contributor Author

Windvis commented Jan 14, 2022 •
edited
Loading

We still need to update the drone file. It uses the danlynn 3.22 images which uses node 12 / npm 6.
Updated to danlynn/ember-cli 3.28.5 because we need a browser to run the tests which madnificent/ember doesn't include yet. The downside is that the image only includes npm 8.1.2 which doesn't support the overrides feature yet. Since we don't use overrides yet, that's good enough for now I think, but ideally we use the same image everywhere. I created madnificent/docker-ember#26 to track that.

@Windvis Windvis marked this pull request as draft January 14, 2022 08:48
@Windvis
Update to the latest madnificent/ember image
44bc747 
This image uses node 16 and npm 8.3 so we pin those versions for volta
users and also update the lock file to match that setup.

We still use danlynn/ember-cli in CI because madnificent/ember doesn't
bundle a browser which we need to run the tests.
@Windvis Windvis marked this pull request as ready for review January 14, 2022 13:00
@Windvis Windvis requested a review from nbittich January 14, 2022 13:03
@nbittich nbittich merged commit 8a0806b into development Jan 14, 2022
@nbittich nbittich deleted the chore/node-16-npm-8.3 branch January 14, 2022 13:04
@Windvis Windvis added the internal Changes that don't introduce new features or bugfixes. label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbittich nbittich Awaiting requested review from nbittich

Assignees
No one assigned
Labels
internal Changes that don't introduce new features or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Windvis @nbittich