Make the rename of zconf a CMake option #519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have the same issue. @madler, could you please review and merge? |
|
@madler, would you please look at this when you have time? We are currently forced to use a fork of zlib because of CMake issues like this. |
joeyparrish
added a commit
to joeyparrish/zlib
that referenced
this pull request
Nov 9, 2022
It has to be regenerated anyway, either through configure or CMake. Having it in the repo means that the CMake build will rename it, dirtying the repo when used as a submodule. A simpler alternative to madler#519
|
Opened #740 as an alternative fix. |
Open
|
Incorporated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I at least, found it annoying that the source zconf.h get renamed when I don't need it too.
Especially while using git submodules, and it says that I have made changes that I need to commit, because of the rename.