nox-review: also offer option to rebuild changed tests #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hum by grouping evaluations in batches I can get down to 15 minutes for a nox-review (2 listings of tests and packages). This adds a new dependency: psutil, to evaluate how much parallelism is acceptable given the amount of free memory. |
Owner
|
Nice work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal was to improve discoverability of tests. Related NixOS/nixpkgs#44439
The result is not so good. It takes more than 10 minutes to evaluate all the tests, and we have to do it twice...
Also installer tests need a copy of nixpkgs as a dependency so everytime something is changed in nixpkgs they need to be rebuilt. We need to blacklist them otherwise it will make nox-review --with-tests really unusable, but I haven't found any better solution than blacklisting by name...