Close file handle after use in generated code

[jonboulle]

h/t @runcom

[runcom]

👍

[jonboulle]

took the liberty of fixing travis too

[madelynnblue]

No need for this to be a defer. Save the results of ReadAll, close, then return.

[runcom]

isn't it the same but w/o having to store the result of ReadAll and check for the error? meh though it's less code like this

[runcom]

also you need to make sure to Close on ReadAll failure as well no?

[runcom]

b, err := ioutil.ReadAll(f)
if err != nil {
    f.Close()
   return nil, err
}
f.Close()
return b, nil

[madelynnblue]

Defer is a slow operation, and so shouldn't be used if there's only one return path. There's no difference in the return values if ReadAll returns an error, so the extra logic you have above doesn't add any value.

[runcom]

I don't understand, if readall fails you still have to close the file

[madelynnblue]

b, err := ioutil.ReadAll(f)
f.Close()
return b, err

[runcom]

Ok i see nvm

[jonboulle]

@mjibson updated