add support for mutiple commands in mqtt message #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along similar lines to the existing support to be able repeat a command multiple times, this adds the ability to specify multiple commands in a single mqtt messasge. Commands are space separated.
|
bump |
|
@maddox just wondering if you've had a chance to take a look at this ? |
|
@maddox still around ? |
|
👋 In order to merge this, it'll need to have the same sort of support for the HTTP api as well. It'll need to be documented in the README too. Thanks! |
|
Sorry missed this comment. Now that I know it is possible to get it in, I'll update to address your suggestions. |
|
Still on my radar just pretty busy these days. |
|
I know its been a long time. Hope to get to this over the holidays |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
harmony-api is a great project. I use mqtt to glue together a lot
of different home automation pieces and it let me quickly add the
ability to connect/issue commands to my tv setup.
I'm current working on Amazon Alexa control for some additional
features (set channel, volume up/down, mute etc.) that don't
seem to be built in with the existing logitech/alexa integration. The
project is https://github.com/mhdawson/AlexaMqttBridge (still a work in
progress so no README.md etc. yet).
Along similar lines to the existing support to be able repeat a command
multiple times, this adds the ability to specify multiple commands in a
single mqtt message. This allows me to create a single mqtt message
from Alexa that changes the TV to a particular channel. For example, by
posting "1 7" on the appropriate mqtt topic the commands for 1 and
7 are sent, changing the channel to 17.
It looks like there are no spaces in the slugs (at least for my devices)
so using spaces to separate the commands seemed safe. If you
think there is a better choice, just let me know and I'll update it.