New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: l1_sync #226

Merged

antiyro merged 1 commit into madara-alliance:main from jbcaron:fix/l1_sync

Aug 12, 2024

Member

jbcaron commented Aug 9, 2024 •

edited

Loading

Pull Request type

Bugfix

What is the current behavior?

the node crash with --sync-l1-disabled option
double l1_gas_price metrics

Resolves: #225
Introduced by: #223

What is the new behavior?

eth client is not created with option --sync-l1-disabled

Does this introduce a breaking change?

No

Other information

The metrics server must be updated accordingly


          fix l1_sync

f7db3f7

antiyro approved these changes

View reviewed changes

Member

antiyro left a comment

Perfect thanks

antiyro merged commit db74dcd into madara-alliance:main

7 checks passed

Member

cchudant commented Aug 19, 2024

introduced by #225 not #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet