Instrumentation using OTEL #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heemankv
force-pushed
the
feature/instrumentation
branch
from
9e369a3
to
07dd003
Compare
heemankv
force-pushed
the
feature/instrumentation
branch
from
02b59df
to
d8bce31
Compare
|
Completed Self Review, resolved OTEL Vars to ENV and Run OTEL only when env var is present. |
heemankv
force-pushed
the
feature/instrumentation
branch
from
929c78e
to
4df6a9a
Compare
apoorvsadana
reviewed
Oct 3, 2024
heemankv
force-pushed
the
feature/instrumentation
branch
from
f84763e
to
76f0109
Compare
apoorvsadana
reviewed
Oct 4, 2024
crates/orchestrator/src/telemetry.rs
Outdated
Comment on lines
30
to
38
| static METER_PROVIDER: Lazy<Arc<SdkMeterProvider>> = Lazy::new(|| { | ||
| let meter_provider = init_metric_provider(); | ||
| Arc::new(meter_provider) | ||
| }); | ||
|
|
||
| static TRACER: Lazy<Arc<Tracer>> = Lazy::new(|| { | ||
| let tracer = init_tracer_provider(); | ||
| Arc::new(tracer) | ||
| }); |
There was a problem hiding this comment.
do we need to still store these?
There was a problem hiding this comment.
Resolved here.
We have to keep both,
TRACER is used while setting for tracing.
global_meter / METRIC_PROVIDER is needed to get the SdkMetricProvider to be used to shutdown the instrumentation.
There was a problem hiding this comment.
discusedd to return these from functions
heemankv
force-pushed
the
feature/instrumentation
branch
from
8ba02e6
to
a4861b1
Compare
ocdbytes
pushed a commit
that referenced
this pull request
Oct 16, 2024
* update: telemetry metric + tracing * update: linting and CI fixes * update: otel env * update: run collector only if env is available * update: correcting otel init * update: removed commented instrumentation * update: generalised db_call_type to function_type * update: otel_enabled, tracing_level, removed tracing logs * update: removed queue/batch size setter + STDOUT code * update: added TRACING_LEVEL to env: * update: fn instrumentation name correction * update: simplifying Level from string logic * update: cleaner + generalised impl for Metrics * update: cleaning new analytics approach * update: correct names for recording otel * update: fixing clippy error * update: adding Sigonz Dashboard * update: tests for otel * update: test cases for telemetry * update: PR comments resolved * update: cleaned the analytics level * update: lint fix * update: CI fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Instrumentation to the orchestrator codebase.
telemetry.rscontaining configs and initialisation files for telemetry data.#instrumentationis added to almost all the functions, they are yet commented, and will only be uncommented as per tracing demands.configis always skipped.EDIT