Remove Colors.plist and fix CI #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychin
force-pushed
the
remove-colors-plist-fix-ci
branch
2 times, most recently
from
4029990 to
55ee9af
Compare
CI is currently failing since :highlight auto-complete relies on loading v:colornames implicitly, but MacVim has its own special handling and parses a bundled Colors.plist file instead, which bypasses the whole system. Colors.plist was added a long time ago as Vim did not have a good cross-platform way to specify colors by names, but this has been alleviated upstream a while ago via runtime/colors/lists/default.vim which gets sourced for default color values. To fix this, simply remove the file, as it serves no purpose anymore. Also remove custom hex color parsing logic which also should simply defer to Vim instead.
ychin
force-pushed
the
remove-colors-plist-fix-ci
branch
from
55ee9af to
117efc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is currently failing since :highlight auto-complete relies on loading v:colornames implicitly, but MacVim has its own special handling and parses a bundled Colors.plist file instead, which bypasses the whole system. Colors.plist was added a long time ago as Vim did not have a good cross-platform way to specify colors by names, but this has been alleviated upstream a while ago via runtime/colors/lists/default.vim which gets sourced for default color values.
To fix this, simply remove the file, as it serves no purpose anymore. Also remove custom hex color parsing logic which also should simply defer to Vim instead.