Repository navigation
Conversation
aquaductape
approved these changes
Dec 11, 2025
gbirman
commented
Dec 11, 2025
| emailResult?.sender || | ||
| result.email_message_search_results.at(1)?.sender || | ||
| idToDisplayName(result.user_id); | ||
| // TODO: display sender for each message in the content hit list |
Contributor
Author
There was a problem hiding this comment.
https://linear.app/macro-eng/issue/M-5398/include-individual-content-hit-senders-in-email-search-response gonna work on this too following
gbirman
deleted the
gab/m-5372-integrate-front-end-pretty-sender-into-search-result
branch
December 11, 2025 21:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In an email search result, we at the moment do not indicate which sender sent which email. that can come later. but in the meantime this aggregates all the senders using .join(, ) with pretty name, which FYI can still default to email in the backend if it does not exist. As you can see in the video below there's still a fair amount of non pretty names and those are still reflected as such when you open the thread. I think getting prettier names from headers or some sort of contact matching if available/possible is up to email service here.
I take a similar approach with the time stamp, using aggregation over hits. https://linear.app/macro-eng/issue/M-5395/email-search-result-created-atupdated-are-incorrect also will fix backend timestamp in results.
Screenshots, GIFs, and Videos
CleanShot.2025-12-11.at.15.52.56.mp4