Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby3[23]: Fix build on 10.4 with gcc14. #27320

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

fhgwright
Copy link
Contributor

This fixes a couple of issues that were warnings until gcc14 made them errors. At least one such issue probably would have caused a crash if the relevant code were executed.

This changes the installed content on 10.4, and hence gets a revbump.

TESTED:
Built successfully on OSX 10.4-10.5 ppc, 10.4-10.6 i386, 10.5-12.x x86_64, and 11.x-14.x arm64. Included all variants compatible with available dependencies on the respective platforms (except ppc builds, which were limited to default variants to save time).

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on
Mac OS X 10.4.11 8S165, PPC, Xcode 2.5 8M2558
Mac OS X 10.4.11 8S2167, i386, Xcode 2.5 8M2558
Mac OS X 10.5.8 9L31a, PPC, Xcode 3.1.4 9M2809
Mac OS X 10.5.8 9L31a, i386, Xcode 3.1.4 9M2809
Mac OS X 10.5.8 9L31a, x86_64, Xcode 3.1.4 9M2809
Mac OS X 10.6.8 10K549, i386, Xcode 3.2.6 10M2518
Mac OS X 10.6.8 10K549, x86_64, Xcode 3.2.6 10M2518
Mac OS X 10.7.5 11G63, x86_64, Xcode 4.6.3 4H1503
OS X 10.8.5 12F2560, x86_64, Xcode 5.1.1 5B1008
OS X 10.9.5 13F1911, x86_64, Xcode 6.2 6C131e
OS X 10.10.5 14F2511, x86_64, Xcode 7.2 7C68
OS X 10.11.6 15G22010, x86_64, Xcode 8.1 8B62
macOS 10.12.6 16G2136, x86_64, Xcode 9.2 9C40b
macOS 10.13.6 17G14042, x86_64, Xcode 10.1 10B61
macOS 10.14.6 18G9323, x86_64, Xcode 11.3.1 11C505
macOS 10.15.7 19H15, x86_64, Xcode 12.4 12D4e
macOS 11.7.10 20G1427, x86_64, Xcode 13.2.1 13C100
macOS 11.7.10 20G1427, arm64, Xcode 13.2.1 13C100
macOS 12.7.6 21H1320, x86_64, Xcode 14.2 14C18
macOS 12.7.6 21H1320, arm64, Xcode 14.2 14C18
macOS 13.7.2 22H313, arm64, Xcode 15.2 15C500b
macOS 14.7.2 23H311, arm64, Xcode 16.2 16C5032a
macOS 15.2 24C101, arm64, Xcode 16.2 16C5032a
Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • [N/A] referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • [NO] tried existing tests with sudo port test? *
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

* - The test framework has issues.

This fixes a couple of issues that were warnings until gcc14 made them
errors.  At least one such issue probably would have caused a crash if
the relevant code were executed.

This changes the installed content on 10.4, and hence gets a revbump.

TESTED:
Built successfully on OSX 10.4-10.5 ppc, 10.4-10.6 i386, 10.5-12.x
x86_64, and 11.x-14.x arm64.  Included all variants compatible with
available dependencies on the respective platforms (except ppc builds,
which were limited to default variants to save time).
@macportsbot
Copy link

Notifying maintainers:
@kimuraw for port ruby32, ruby33.

@macportsbot macportsbot added type: bugfix maintainer maintainer: open Affects an openmaintainer port labels Jan 7, 2025
@fhgwright
Copy link
Contributor Author

This supersedes #27024, which should be closed.

@fhgwright fhgwright mentioned this pull request Jan 7, 2025
12 tasks
@kencu kencu merged commit df165ef into macports:master Jan 7, 2025
3 checks passed
@fhgwright fhgwright deleted the ruby3x branch January 7, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants