Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py-scikit-image: update to 0.25.0, add py313 subport #27291

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

py-scikit-image: update to 0.25.0, add py313 subport #27291

wants to merge 1 commit into from

Conversation

erikbs
Copy link
Contributor

@erikbs erikbs commented Jan 4, 2025 •
edited
Loading

Description

  • Update to 0.25.0 for Python >= 3.10
  • Pin to 0.24.0 for Python 3.9
  • Add py313 subport

Depends on #27290, #27289 and #27287, but is otherwise ready for review.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.9.5 13F1911 x86_64
Xcode 6.2 6C131e

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

No binary files. Tested by importing the module and testing a function (skimage.morphology.remove_small_objects).

@erikbs
py-scikit-image: update to 0.25.0, add py313 subport
1bafaf2 
* Update to 0.25.0 for Python >= 3.10
* Pin to 0.24.0 for Python 3.9
* Add py313 subport
@macportsbot
Copy link

Notifying maintainers:
@stromnov for port py-scikit-image.

erikbs
erikbs commented Jan 4, 2025
View reviewed changes
python/py-scikit-image/Portfile
post-patch {
reinplace "s|#!/usr/bin/env python|#!/usr/bin/env python3|" \
reinplace "s|#!/usr/bin/env python$|#!/usr/bin/env python3|" \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this change is to prevent the shebang from becoming python33, as one of the files in this folder (version.py) had python changed to python3 recently. The reinplace statement will issue a warning for that file about it not doing anything.

@reneeotten
Copy link
Contributor

@erikbs please rebase with master so we can see whether the CI builds pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stromnov stromnov

Labels
maintainer: open Affects an openmaintainer port type: enhancement type: update
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erikbs @macportsbot @reneeotten @stromnov