retdec: new port

[catap]

Description

Added a new port for https://github.com/avast/retdec. The port contains also -devel version which is used current master.

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 11.5.1 20G80 x86_64
Xcode 12.5.1 12E507

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?
• checked your Portfile with port lint?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[catap]

@reneeotten and port doesn't build because it can't downloads dependency on azure, as far as I can see. Anyway, I've tried to fresh installed 10.14 and both ports builded sucessfuly.

[catap]

@reneeotten and right now azure is failed with error:

Creating port index in /Users/runner/work/1/s/ports
Adding port devel/retdec
Adding subport retdec-devel
Failed to parse file multimedia/x265/Portfile: can't read "universal_possible": no such variable

[reneeotten]

@reneeotten and right now azure is failed with error:

Creating port index in /Users/runner/work/1/s/ports
Adding port devel/retdec
Adding subport retdec-devel
Failed to parse file multimedia/x265/Portfile: can't read "universal_possible": no such variable

Yeah, ignore that - Azure still doesn't use the latest MacPorts version but still v1.6.x and the universal_possible I think was introduced in v1.7.x.

[kencu]

This looks like a desirable port to have in MacPorts. Good job getting it sorted out.

With the way it uses so many internal deps, it will never fil our "usual" model, but perhaps that is OK. It will be somewhat harder to repair older systems, etc, but I think that's OK too.

There will be lots of quibbles about smaller things that get worked out, eg git is a bin path dep, but those can all get tweaked as well.

If it builds and runs on the last few systems, and installs things where they belong, and generally actually works, we can likely beautify it as much as possible once it is in.

[catap]

@kencu thanks!

Yes, it is working very well on Big Sur (my laptop), and I used -devel port to get this decompiled output https://gist.github.com/catap/075abf613c7946c8ec972fa123bf8b7e from a binary which is produce by scala-native ;)

[reneeotten]

@catap I am trying to build this locally now; there are still some changes needed I think. Are you okay, with me pushing one additional commit with the things that I need are still needed to your branch? If so, I'll do that tonight and you can take a look - if you agree and everything looks good we can squash the commits and merge.

Also, does building in parallel not work - since you added the non-default use_parallel_build no?

[catap]

@reneeotten I'm more than ok to your help with this port because it consumed much more time than I've expected to invest to it ;) Thus, I've just incited you and now you should has write access to original branch that was used to create this PR.

Parallel building is working fine but it consumes huge amount of memory, much more than GitHub is limited for CI. Without it CI is fails. I feel that it may create an issue with prebuidled version.

I suggest to remove it before merge to master.

[reneeotten]

@catap I have pushed a commit with some additional changes (listed in the commit message). One remaining annoying issue is that this building of many dependencies do not all UsingTheRightCompiler. I fixed one of them, but it now fails with the next one (yaramod). You can follow the link I gave above to set-up your local installation such that it will spot these/complain about such occurrences.

[catap]

@reneeotten which OS have you used to test it and active fails?

[reneeotten]

@reneeotten which OS have you used to test it and active fails?

I've tested this on 10.15.7 ; but it isn't OS dependent - if you follow the instructions for testing in the link I gave about UsingTheRightCompiler you should be able to reproduce this anywhere.

[catap]

@reneeotten thanks, I haven't no about this elegant way to track wrong configure settings! ;)

[reneeotten]

@catap sorry, I got distracted... have you figured out how to make sure that the correct compiler is used for everything? If so, I can give this another go locally myself and then it should hopefully be ready-to-go...

[catap]

@reneeotten yep, I did. Right bow it should work fine.

[reneeotten]

@reneeotten yep, I did. Right bow it should work fine.

I just tried this locally and indeed it now is UsingTheRightCompiler - great! However, I see some weirdness in where files are installed... A lot of things are installed correctly in the ${prefix}, but there are also files in /opt/local/var/macports/build/_Users_renee_Software_macports-ports_devel_retdec/retdec/work/destroot/opt/local/share/retdec/support/x86/ords/wmpencen.ord. That doesn't seem right... can you check whether that happens for you as well port contents retdec. I suspect it might have to do with the reinplaces in the Portfile, but would need to look at that a bit closer.

[catap]

@reneeotten very good catch!

I've solved it. Anyway, it required some time figure it out.

[reneeotten]

@reneeotten very good catch!

I've solved it. Anyway, it required some time figure it out.

Excellent - it looks like all files are now indeed installed in proper locations. Anyway, this PR has been open long enough for people to comment on it, which didn't really happen - so I guess nobody has any further comments ;) Let's merge this and if something comes up, that can be taken care of afterwards. Thanks @catap !