-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"ModuleNotFoundError" when using Python 3.12 #181
Comments
@Delgan thanks a lot for the report. Otherwise I'll try to get to it within a week (or so). |
Thanks for the quick reply. I opened #182. ;) |
Would you be able to create a new tag with this included? |
milesziemer
added a commit
to milesziemer/smithy-rs
that referenced
this issue
Nov 21, 2023
Was running into macisamuele/language-formatters-pre-commit-hooks#181 trying to run pre-commit. It was fixed in 2.11.
github-merge-queue bot
pushed a commit
to smithy-lang/smithy-rs
that referenced
this issue
Nov 21, 2023
Was running into macisamuele/language-formatters-pre-commit-hooks#181 trying to run pre-commit. It was fixed in 2.11. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
github-merge-queue bot
pushed a commit
to smithy-lang/smithy-rs
that referenced
this issue
Nov 21, 2023
Was running into macisamuele/language-formatters-pre-commit-hooks#181 trying to run pre-commit. It was fixed in 2.11. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
rcoh
pushed a commit
to milesziemer/smithy-rs
that referenced
this issue
Nov 21, 2023
Was running into macisamuele/language-formatters-pre-commit-hooks#181 trying to run pre-commit. It was fixed in 2.11.
github-merge-queue bot
pushed a commit
to smithy-lang/smithy-rs
that referenced
this issue
Nov 24, 2023
Was running into macisamuele/language-formatters-pre-commit-hooks#181 trying to run pre-commit. It was fixed in 2.11. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ Co-authored-by: Russell Cohen <[email protected]>
jdisanti
pushed a commit
to smithy-lang/smithy-rs
that referenced
this issue
Nov 27, 2023
Was running into macisamuele/language-formatters-pre-commit-hooks#181 trying to run pre-commit. It was fixed in 2.11. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ Co-authored-by: Russell Cohen <[email protected]>
ysaito1001
pushed a commit
to smithy-lang/smithy-rs
that referenced
this issue
Nov 28, 2023
Was running into macisamuele/language-formatters-pre-commit-hooks#181 trying to run pre-commit. It was fixed in 2.11. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ Co-authored-by: Russell Cohen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi!
Python 3.12 final release is scheduled for the next month and they removed some bundled libraries like notably
pkg_resources
:The problem is that
language-formatters-pre-commit-hooks
depends onpkg_resources
here:language-formatters-pre-commit-hooks/language_formatters_pre_commit_hooks/__init__.py
Line 2 in 9c4cf43
When using Python 3.12, this causes my pre-commit to fail with the following error:
I guess
setuptools
should be added as an explicit dependency to this project insetup.cfg
?The text was updated successfully, but these errors were encountered: