C++ function wrapper #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved error handling so that library doesn't !panic, but returns an error code. Handle the error inside your program instead of your program unexpectedly exiting.
|
Ahoy! I do not want to belay your efforts, but putting these functions and their imports into the
The second has the advantage that build times do not increase for those who only use this crate from Rust. And has the disadvantage that it is difficult to notice your crate when someone only knows this one. Although I sometimes check the dependent crates of a crate to see how they are used: https://crates.io/crates/tiny-bip39/reverse_dependencies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day,
I've created C++ library access functions in lib.rs.
The C++ header file and demo application is contained inside the C++ sub directory.