fix(mooncake): address review comments on HBM leak fix

[Copilot]

Three correctness issues in the MooncakeConnectorWorker race-condition fixes from the original HBM leak PR.

Changes

• Consolidate reqs_to_recv mutations into receiver_loop: Move self.reqs_to_recv.update() from start_load_kv() (main thread) into _start_load_kv() (runs in receiver_loop). All reads and writes to reqs_to_recv now happen in a single event loop — no cross-thread race, no defensive copies needed.

• Remove list() copies in fetch_finished_recving_reqs: With reqs_to_recv access confined to receiver_loop, the copies guarding against concurrent iteration are unnecessary.

• Fix silent drop of err_reqs on ERROR response: process_pulling_result() was called after the ERROR early-return, so failed requests never reached finished_recving_reqs and were never cleaned up by the scheduler.

# Before: err_reqs silently dropped
if response.status == MooncakeXferResponseStatus.ERROR:
    return                            # process_pulling_result never called
self.process_pulling_result(response, pull_metas)

# After: err_reqs always forwarded to finished_recving_reqs
self.process_pulling_result(response, pull_metas)
if response.status == MooncakeXferResponseStatus.ERROR:
    return

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/repos/machov/vllm
  • Triggering command: /usr/bin/curl curl -si -H Authorization: token ****** REDACTED (http block)
• https://api.github.com/repos/machov/vllm/git/refs/heads/copilot%2Ffix-mooncake-hbm-leak-temp
  • Triggering command: /usr/bin/curl curl -s -X PATCH -H Authorization: token ****** -H Accept: application/vnd.github.v3+json REDACTED -d {"sha": "b786e59514ecddb92c51a4891f42e2f62a05e476", "force": true} (http block)
  • Triggering command: /usr/bin/curl curl -sv -X PATCH -H Authorization: token ****** -H Accept: application/vnd.github.v3+json -H Content-Type: application/json REDACTED -d {"sha": "b786e59514ecddb92c51a4891f42e2f62a05e476", "force": true} (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.