Remove preflight stage login window assumption #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the code that checks for the login window when executing the preflight stage of installapplications.py, and updates the README to reflect this change. Previously, if the preflight stage were run at the loginwindow, installapplications assumed it was running on a new machine. While this assumption may hold for certain workflows, certain MDM setups or workflows may include sending the InstallApplication MDM command to a device at the loginwindow, which would automatically skip the preflight and it would sit there until next user logged in. This may result in unintended DEPNotify runs and/or logouts/restarts for users with previously deployed and configured machines. This assumption has been removed to instead allow the preflight script to handle this logic.
|
Knew this would be super simple. Can you do me one favor and update the example JSON on the readme with the preflight, and explicitly on the script make the donotwaitkey false? |
|
How's that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the code that checks for the login window when executing the preflight stage of installapplications.py, and updates the README to reflect this change.
Previously, if the preflight stage were run at the loginwindow, installapplications assumed it was running on a new machine. While this assumption may hold for certain workflows, certain MDM setups or workflows may include sending the InstallApplication MDM command to a device at the loginwindow, which would automatically skip the preflight and it would sit there until next user logged in. This may result in unintended DEPNotify runs and/or logouts/restarts for users with previously deployed and configured machines. This assumption has been removed to instead allow the preflight script to handle this logic.