Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Node.js v20 for the GitHub Actions Library [MABL-13559] #61

Merged
merged 4 commits into from
May 21, 2024
Merged

Upgrade to Node.js v20 for the GitHub Actions Library [MABL-13559] #61

merged 4 commits into from
May 21, 2024
+2,977 −1,442

Conversation

twistedpair
Copy link
Contributor

Address GitHub Actions deprecation warnings around the Node.js version used to run the GitHub Action itself.

Additionally:

  • Upgrades the core GitHub Actions libraries
  • Bumps the minumum runtime (not GitHub Actions) Node.js version to 18
  • Updates the installation testing matrix used in building the action
  • Fixes a breaking test harness due to a change in GH Actions that's returning error codes on exit

@twistedpair twistedpair requested review from a team May 21, 2024 06:17
@twistedpair
Copy link
Contributor Author

Addresses #60

jeffreyzupka
jeffreyzupka approved these changes May 21, 2024
View reviewed changes
Copy link

@jeffreyzupka jeffreyzupka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@twistedpair twistedpair changed the title Upgrade to Node.js v20 for the GitHub Actions Library Upgrade to Node.js v20 for the GitHub Actions Library [MABL-13559] May 21, 2024
@twistedpair twistedpair merged commit c3a4b51 into main May 21, 2024
3 checks passed
@twistedpair twistedpair deleted the node-20-upgrade branch May 21, 2024 15:15
@twistedpair twistedpair mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbaldassari jbaldassari jbaldassari approved these changes

@jeffreyzupka jeffreyzupka jeffreyzupka approved these changes

@terryknowlton terryknowlton terryknowlton approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@twistedpair @jbaldassari @jeffreyzupka @terryknowlton