Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Elixir structs #2

Merged

Conversation

colinsmetz
Copy link
Contributor

Many of the modules defined in datatypes.rs do not have an equivalent struct in the Elixir code, so we receive structs that Elixir does not recognize and have to match explicitly on %{__struct__: module, ...} which is a bit annoying.

Is it possible to add them?

Also, would you prefer to add tests for each of them before adding them?

@maartenvanvliet
Copy link
Owner

maartenvanvliet commented Apr 17, 2023

Thanks! Test cases for each of them are not necessary imo. I'd rather see some kitchen sink integration tests eventually. And some property tests to see if the sql -> rust -> elixir -> rust -> sql conversion works out.

@colinsmetz colinsmetz force-pushed the add-missing-elixir-structs branch from 17c6633 to 9e71ca0 Compare April 17, 2023 13:38
@maartenvanvliet maartenvanvliet merged commit f03768c into maartenvanvliet:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants