Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
First of all, thank you for that project, it is really nice :)
However, to be able to use it, we would need to have the
-musl
builds which are missing. I see that they have been removed in this commit. I'm not sure if there is a specific reason besides the fact that the compilation could not work without the appropriate options.In any case, if you agree to add it, this PR should make it work (it did work on our fork).
I have also added the
Cross.toml
file, which is mentioned in the Precompilation guide. I am not sure theRUSTLER_NIF_VERSION
is actually used without that file.