Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support musl targets #1

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

colinsmetz
Copy link
Contributor

Hello !

First of all, thank you for that project, it is really nice :)

However, to be able to use it, we would need to have the -musl builds which are missing. I see that they have been removed in this commit. I'm not sure if there is a specific reason besides the fact that the compilation could not work without the appropriate options.

In any case, if you agree to add it, this PR should make it work (it did work on our fork).

I have also added the Cross.toml file, which is mentioned in the Precompilation guide. I am not sure the RUSTLER_NIF_VERSION is actually used without that file.

@maartenvanvliet
Copy link
Owner

Hi, thank you!!

I left out musl because of some other rustler projects I worked on where it didn't work in CI, so I didn't want to put in the effort. But it's not an issue here :)

There are still parts of SQL missing in the rust->elixir conversion so be mindful of that when using the library.

@maartenvanvliet maartenvanvliet merged commit 94da681 into maartenvanvliet:main Apr 17, 2023
@colinsmetz
Copy link
Contributor Author

Thanks for accepting the PR!

There are still parts of SQL missing in the rust->elixir conversion so be mindful of that when using the library.

Sure, I have seen that. We only need basic operations for now so it's not a problem :)

We'd be happy to contribute other improvements in the future if we need more features you are open to other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants