fix: address security findings on path traversal, hardening - #2
Merged
Conversation
ma-04
commented
Aug 20, 2026
ma-04
commented
Owner
- Contain screenmemory:// and screenshot IPC paths inside the storage root (src/main/path-containment.ts) instead of an unchecked path.join
- Encrypt the stored AI API key via safeStorage, expose it to the renderer only as an ai.hasApiKey flag (src/main/secret-store.ts, db/repositories/settings.ts)
- Allowlist and validate every settings key/value pair before persisting, including an AI base-URL host allowlist (src/main/settings-validation.ts)
- Add navigation, window-open, and permission-request guards plus a session-wide CSP (src/main/security.ts), replacing the CSP meta tag
- Redact likely secrets out of OCR text before it reaches the AI prompt (src/main/redact.ts)
- Drop risky mac entitlements, gate DevTools/reload to unpackaged builds, and SHA-pin third-party GitHub Actions
- Fix a settings-input rollback race and delete unused dead code that still returned the decrypted API key
…web hardening - Contain screenmemory:// and screenshot IPC paths inside the storage root (src/main/path-containment.ts) instead of an unchecked path.join - Encrypt the stored AI API key via safeStorage, expose it to the renderer only as an ai.hasApiKey flag (src/main/secret-store.ts, db/repositories/settings.ts) - Allowlist and validate every settings key/value pair before persisting, including an AI base-URL host allowlist (src/main/settings-validation.ts) - Add navigation, window-open, and permission-request guards plus a session-wide CSP (src/main/security.ts), replacing the CSP meta tag - Redact likely secrets out of OCR text before it reaches the AI prompt (src/main/redact.ts) - Drop risky mac entitlements, gate DevTools/reload to unpackaged builds, and SHA-pin third-party GitHub Actions - Fix a settings-input rollback race and delete unused dead code that still returned the decrypted API key Verified against security-issues.md in security-issues-verified.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.