Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CommUtil #38

Merged
merged 1 commit into from
May 25, 2021
Merged

Remove CommUtil #38

merged 1 commit into from
May 25, 2021

Conversation

ikedam
Copy link
Contributor

@ikedam ikedam commented May 3, 2021

Removed CommUtil, which is licensed under LGPL 2.1. See #21 for more details about the license.

I believe CommUtil is useless as:

@ikedam
Remove CommUtil
fa1627b 
* They are not documented in https://docs.m5stack.com/en/api/m5paper/system_api
* It looks a copy of that in M5 core. But this doesn't work as M5 core as this is connected not to Grove-A port, but to the internal port in M5 paper.
@ikedam ikedam mentioned this pull request May 3, 2021
Merged
@Gitshaoxiang
Copy link
Contributor

Thank for your help

@Gitshaoxiang Gitshaoxiang merged commit 9d478a4 into m5stack:main May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikedam @Gitshaoxiang