Limit the number of items per exhibit on web and mobile platforms#144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Meta Quest 3, on very large exhibits with enough items, it would tank the frame rate into single digits and even crash the app
(I tested mostly with the "Screenshot" article, and it could pretty reliably crash it, if you waited long enough for all 2500+ items to load)
This limits the number of slots per exhibit to approximately ~200 on web and mobile (it can go a little over - it stops adding rooms to an exhibit once it goes over, but it'll add however many slots for the last room). On all other platforms, it limits to ~2500, which is about where the limit was anyway, because that's the maximum number of images that would be pulled from Wikimedia Commons.
This does mean that exhibits will be different between web/mobile and all other platforms. But, without having texture streaming and occlusion culling (which would be quite a lot of work to implement), I don't think we can have exhibits that big on web/mobile
After this change, I haven't been able to get MOAT to crash at all on any articles on the Meta Quest 3!