Hide all exhibits except the current one to improve performance#143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to improve rendering performance, this PR will hide all exhibits (including the lobby) that the user isn't presently in.
It works by having a
GridMapas part of eachGridWrapper.gdinstance, rather than using only the singleGridMapthat's part of the Lobby. And, then it uses aGridManager.gdautoload to keep track of all the cells on allGridMaps, so that they can't accidentally overlap in exhibit generation.For the
GridManager.gd, I had originally thought that I'd need to group the cells into octants in order to be performant enough, but in my testing, just keeping all the cells on the sameDictionaryseems to work fine! If we ever have issues later, we can switch to octantsThis dramatically improves performance on the Meta Quest, but should help on all platforms