Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated example + export of target_lexcion #117

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Updated example + export of target_lexcion #117

merged 2 commits into from
Apr 8, 2024

Conversation

Cr0a3
Copy link
Contributor

@Cr0a3 Cr0a3 commented Mar 27, 2024

Hi,
In this pull request i exported the target_lexcion module, so you don't need to have it as a dependency when working with this libary.
Also, i added an example simple.rs, which just is the code from the readme.
In the ReadMe i made it so that you can just copy the example and it is runnable.

@Cr0a3
Copy link
Contributor Author

Cr0a3 commented Mar 29, 2024

@m4b

@m4b
Copy link
Owner

m4b commented Apr 1, 2024

seems to need a rustfmt; fixing the double import warning would be nice too (not sure if CI will also fail from it, probably)

@Cr0a3
Copy link
Contributor Author

Cr0a3 commented Apr 2, 2024

Ok i will fix it

@Cr0a3
Copy link
Contributor Author

Cr0a3 commented Apr 3, 2024

I fixed the rustfmt but i didn't got the double import warning

@Cr0a3
Copy link
Contributor Author

Cr0a3 commented Apr 7, 2024

@m4b

@m4b
Copy link
Owner

m4b commented Apr 8, 2024

macos linkage has begun failing apparently; i will merge this but i don't have time to debug why that is

@m4b m4b merged commit 8ac6e28 into m4b:master Apr 8, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants