chore: add tests for gokart parameters #389
Merged
+24
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiro-o918
force-pushed
the
chore/add-tests-gokart-params
branch
3 times, most recently
from
c225dd9 to
534035d
Compare
hiro-o918
force-pushed
the
chore/add-tests-gokart-params
branch
from
f5b2df0 to
c08ba6d
Compare
hiro-o918
commented
Aug 1, 2024
| @@ -404,9 +406,13 @@ def is_parameter_call(expr: Expression) -> bool: | |||
| type_info = callee.node | |||
| if type_info is None and isinstance(callee.expr, NameExpr): | |||
| return PARAMETER_FULLNAME_MATCHER.match(f'{callee.expr.name}.{callee.name}') is not None | |||
| if isinstance(type_info, TypeInfo) and PARAMETER_FULLNAME_MATCHER.match(type_info.fullname): | |||
| return True | |||
| elif isinstance(callee, NameExpr): | |||
There was a problem hiding this comment.
These conditions are very complicated to review, because these lines are determined by print debugging by tests.
So please check the test cases for this update
hiro-o918
commented
Aug 1, 2024
|
|
||
| # TaskOnKart parameters: | ||
| # - `complete_check_at_run` | ||
| MyTask(foo=1, bar='bar', baz=False, complete_check_at_run=False) |
There was a problem hiding this comment.
Add complete_check_at_run parameter to check #388 is resolved
hiro-o918
commented
Aug 1, 2024
| MyTask(foo='1') | ||
| # TaskOnKart parameters: | ||
| # - `complete_check_at_run` | ||
| MyTask(foo='1', baz='not bool', complete_check_at_run='not bool') |
There was a problem hiding this comment.
We can also check invalid type for the attributes of gokart.TaskOnKart
kitagry
reviewed
Aug 1, 2024
gokart/mypy.py
Outdated
| # the transformation does not affect because the class has `__init__` method of `gokart.TaskOnKart`. | ||
| # | ||
| # NOTE: `gokart.task.luigi.Task` condition is required for the release of luigi versions without py.typed | ||
| if fullname == 'gokart.task.luigi.Task' or fullname == 'luigi.task.Task': |
There was a problem hiding this comment.
Suggested change
| if fullname == 'gokart.task.luigi.Task' or fullname == 'luigi.task.Task': | |
| if fullname in ['gokart.task.luigi.Task', 'luigi.task.Task']: |
kitagry
approved these changes
Aug 1, 2024
hiro-o918
force-pushed
the
chore/add-tests-gokart-params
branch
from
c08ba6d to
fcb8be8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #388