feat: update plugin overcomes conflicting parameter types #386
+148
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiro-o918
force-pushed
the
feature/precise-type-annotation
branch
2 times, most recently
from
e94c7b3 to
b8df029
Compare
hiro-o918
changed the title
hiro-o918
force-pushed
the
feature/precise-type-annotation
branch
from
2da0e1c to
e39344f
Compare
hiro-o918
force-pushed
the
feature/precise-type-annotation
branch
13 times, most recently
from
75893d5 to
18cefdf
Compare
hiro-o918
changed the title
hiro-o918
commented
Jul 20, 2024
| # As the following code snippet, the type of `foo` is `int` but the assigned value is `luigi.IntParameter()`. | ||
| # foo: int = luigi.IntParameter() | ||
| # TODO: infer mypy type from the parameter type. | ||
| return AnyType(TypeOfAny.unannotated) |
There was a problem hiding this comment.
If no default value, a parameter handled as AnyType(TypeOfAny.unannotated)
Due to this, type annotation for the TaskOnKart takes precedence.
hiro-o918
force-pushed
the
feature/precise-type-annotation
branch
from
18cefdf to
cfbbcaa
Compare
hiro-o918
force-pushed
the
feature/mypy-plugin
branch
4 times, most recently
from
ec0013c to
08e2b74
Compare
hiro-o918
force-pushed
the
feature/precise-type-annotation
branch
from
cfbbcaa to
448b4ae
Compare
hiro-o918
force-pushed
the
feature/precise-type-annotation
branch
from
a0768e9 to
51cd342
Compare
hiro-o918
force-pushed
the
feature/precise-type-annotation
branch
from
51cd342 to
a31a847
Compare
hiro-o918
commented
Jul 22, 2024
| @@ -59,7 +59,7 @@ def set_task_lock(task_lock_params: TaskLockParams) -> redis.lock.Lock: | |||
|
|
|||
| def set_lock_scheduler(task_lock: redis.lock.Lock, task_lock_params: TaskLockParams) -> BackgroundScheduler: | |||
| scheduler = BackgroundScheduler() | |||
| extend_lock = functools.partial(_extend_lock, task_lock=task_lock, redis_timeout=task_lock_params.redis_timeout) | |||
| extend_lock = functools.partial(_extend_lock, task_lock=task_lock, redis_timeout=task_lock_params.redis_timeout or 0) | |||
There was a problem hiding this comment.
_extend_lock does not accept optional value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
update plugin overcomes conflicting parameter types
Any(unannotated)and use type annotationsFuture Work
#387